[Caffe2] Add AT_CORE_EXPORT and AT_CORE_IMPORT.#10602
Closed
xkszltl wants to merge 2 commits intopytorch:masterfrom
Closed
[Caffe2] Add AT_CORE_EXPORT and AT_CORE_IMPORT.#10602xkszltl wants to merge 2 commits intopytorch:masterfrom
xkszltl wants to merge 2 commits intopytorch:masterfrom
Conversation
Fix "error LNK2019: unresolved external symbol" from "CAFFE_KNOWN_TYPE" in tests where we should use dllexport instead of AT_CORE_API(=dllimport).
Contributor
Author
|
For #10601 |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
Yangqing is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 17, 2018
Summary: Fix "error LNK2019: unresolved external symbol" from "CAFFE_KNOWN_TYPE" in tests where we should use dllexport instead of AT_CORE_API(=dllimport). Pull Request resolved: pytorch/pytorch#10602 Differential Revision: D9377394 Pulled By: Yangqing fbshipit-source-id: 993062a461ffce393f2321c5391db5afb9b4e7ba
Yangqing
reviewed
Aug 17, 2018
| // create attribute ignored error for explicit template instantiations, see | ||
| // http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0537r0.html | ||
| // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51930 | ||
| // and as a result, we define these two macros slightly differently. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
|
(note: revert done in b4e72ea) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix "error LNK2019: unresolved external symbol" from "CAFFE_KNOWN_TYPE" in tests where we should use dllexport instead of AT_CORE_API(=dllimport).