[Caffe2] Delete copy constructor/assignment of class Observable explicitly.#10593
Closed
xkszltl wants to merge 1 commit intopytorch:masterfrom
Closed
[Caffe2] Delete copy constructor/assignment of class Observable explicitly.#10593xkszltl wants to merge 1 commit intopytorch:masterfrom
xkszltl wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
Author
|
For #10576 |
This should resolves "error C2280: 'std::unique_ptr<caffe2::ObserverBase<caffe2::OperatorBase>,std::default_delete<_Ty>> &std::unique_ptr<_Ty,std::default_delete<_Ty>>::operator =(const std::unique_ptr<_Ty,std::default_delete<_Ty>> &)': attempting to reference a deleted function" from Visual Studio. It should also make error message more human-readable in case if something really messed up.
mingzhe09088
approved these changes
Aug 21, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
mingzhe09088 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
…ytorch#10593) Summary: This should resolves "error C2280: 'std::unique_ptr<caffe2::ObserverBase<caffe2::OperatorBase>,std::default_delete<_Ty>> &std::unique_ptr<_Ty,std::default_delete<_Ty>>::operator =(const std::unique_ptr<_Ty,std::default_delete<_Ty>> &)': attempting to reference a deleted function" from Visual Studio. It should also make error message more human-readable in case if something really messed up. Pull Request resolved: pytorch#10593 Reviewed By: orionr Differential Revision: D9436397 Pulled By: mingzhe09088 fbshipit-source-id: 31711667297b4160196134a34365da734db1c61d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolves "error C2280: 'std::unique_ptr<caffe2::ObserverBasecaffe2::OperatorBase,std::default_delete<_Ty>> &std::unique_ptr<_Ty,std::default_delete<_Ty>>::operator =(const std::unique_ptr<_Ty,std::default_delete<_Ty>> &)': attempting to reference a deleted function" from Visual Studio.
It should also make error message more human-readable in case if something really messed up.