Skip to content

fix lint#105675

Closed
PaliC wants to merge 1 commit intogh/PaliC/188/basefrom
gh/PaliC/188/head
Closed

fix lint#105675
PaliC wants to merge 1 commit intogh/PaliC/188/basefrom
gh/PaliC/188/head

Conversation

@PaliC
Copy link
Copy Markdown
Contributor

@PaliC PaliC commented Jul 20, 2023 •
edited by albanD
Loading

Stack from ghstack (oldest at bottom):

Forward fix of the lint issues introduced by #104242
We are forward fixing as this PR contains Meta internal changes that would be tricky to revert smoothly.

@PaliC
fix lint
5d5aa26 
[ghstack-poisoned]
@PaliC PaliC requested a review from jerryzh168 as a code owner July 20, 2023 16:49
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 20, 2023
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jul 20, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105675

Note: Links to docs will display an error until the docs builds have been completed.

✅ 3 Unrelated Failures

As of commit 5d5aa26:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

PaliC added a commit that referenced this pull request Jul 20, 2023
@PaliC
fix lint
5056637 
ghstack-source-id: e0286ce
Pull Request resolved: #105675
@github-actions github-actions bot added the release notes: quantization release notes category label Jul 20, 2023
@PaliC
Copy link
Copy Markdown
Contributor Author

PaliC commented Jul 20, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 20, 2023
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 20, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@seemethere
Copy link
Copy Markdown
Member

seemethere commented Jul 20, 2023

Can we link the PR where the lint failures started?

albanD
albanD approved these changes Jul 20, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@huydhn
Copy link
Copy Markdown
Contributor

huydhn commented Jul 20, 2023

@pytorchbot merge -f 'Lint jobs have passed, get this merge to fix trunk'

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 20, 2023

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 20, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/PaliC/188/head branch July 24, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

@albanD albanD albanD approved these changes

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: quantization release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@PaliC @pytorchmergebot @seemethere @huydhn @jerryzh168 @albanD @atalman