Add subname to console output for assertExpected#10559
Closed
driazati wants to merge 1 commit intopytorch:masterfrom
driazati:test
Closed
Add subname to console output for assertExpected#10559driazati wants to merge 1 commit intopytorch:masterfrom driazati:test
driazati wants to merge 1 commit intopytorch:masterfrom
driazati:test
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
ezyang
reviewed
Aug 15, 2018
| ("I got this output for {}{}:\n\n{}\n\n" | ||
| "No expect file exists; to accept the current output, run:\n" | ||
| "python {} {} --accept").format(munged_id, s, __main__.__file__, munged_id)) | ||
| "python {} {} --accept").format(munged_id, subname_output, s, __main__.__file__, munged_id)) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Running `--accept` on a test doesn't tell you explicitly which sub-test is being updated, this PR fixes that Pull Request resolved: pytorch#10559 Differential Revision: D9353977 Pulled By: driazati fbshipit-source-id: a9d4014386ff0fe388a092f3dcf50f157e460f04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
--accepton a test doesn't tell you explicitly which sub-test is being updated, this PR fixes that