Fix leaking of Storages (not StorageImpls)#10552
Closed
gchanan wants to merge 1 commit intopytorch:masterfrom
Closed
Fix leaking of Storages (not StorageImpls)#10552gchanan wants to merge 1 commit intopytorch:masterfrom
gchanan wants to merge 1 commit intopytorch:masterfrom
Conversation
Summary: Fix leaking of Storages (not StorageImpls) Reviewed By: li-roy Differential Revision: D9349824 fbshipit-source-id: d492d7d62be393cbc5955440278bd605e04767a4
soumith
approved these changes
Aug 15, 2018
Contributor
|
Note to the peanut gallery: this code is bad and will be fixed properly in #10488 |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 16, 2018
Summary: Pull Request resolved: pytorch/pytorch#10552 Fix leaking of Storages (not StorageImpls) Reviewed By: li-roy Differential Revision: D9349824 fbshipit-source-id: 31f14951020a63189bebda25a3bf8bf195cd227f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Fix leaking of Storages (not StorageImpls)
Reviewed By: li-roy
Differential Revision: D9349824