Skip to content

fix python interpreter can not be found#10543

Closed
pohmelie wants to merge 1 commit intopytorch:masterfrom
pohmelie:add-missed-PYTHON_EXECUTABLE
Closed

fix python interpreter can not be found#10543
pohmelie wants to merge 1 commit intopytorch:masterfrom
pohmelie:add-missed-PYTHON_EXECUTABLE

Conversation

@pohmelie
Copy link
Contributor

Custom python installation, which have no aliases to python or python3 can't be found by cmake findPythonInterp without extra cmake argument.

@ezyang
Copy link
Contributor

ezyang commented Aug 17, 2018

Nice catch.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ezyang
Copy link
Contributor

ezyang commented Aug 17, 2018

@pohmelie Unfortunately, this seemed to fail tests after merging into master, and we had to unland it. Do you know why that may have happened?

@pohmelie
Copy link
Contributor Author

pohmelie commented Aug 17, 2018 via email

@pohmelie
Copy link
Contributor Author

@ezyang
Ok, the problem is here
https://ci.pytorch.org/jenkins/job/pytorch-builds/job/pytorch-linux-trusty-py3.6-gcc7-build/6494//consoleFull

15:31:54 + cmake /var/lib/jenkins/workspace -DPYTHON_EXECUTABLE= -DBUILDING_WITH_TORCH_LIBS=ON

It looks like some build-script do not use setup.py and do not set PYTORCH_PYTHON environment variable. I'm not familiar with jenkins and have no luck with search, but this should be easy to fix two ways:

  • fix test script, so there is needed environment variable
  • update pull request, so it will check for PYTORCH_PYTHON is available

facebook-github-bot pushed a commit that referenced this pull request Aug 18, 2018
…10659)

Summary:
Take 2 of #10543
The problem was that between commit and merge there was added one more run point `tools/build_libtorch.py`.
Pull Request resolved: #10659

Differential Revision: D9393540

Pulled By: soumith

fbshipit-source-id: 8ebfed600fc735fd1cb0489b161ec80e3db062e0
PenghuiCheng pushed a commit to PenghuiCheng/pytorch that referenced this pull request Sep 11, 2018
…ytorch#10659)

Summary:
Take 2 of pytorch#10543
The problem was that between commit and merge there was added one more run point `tools/build_libtorch.py`.
Pull Request resolved: pytorch#10659

Differential Revision: D9393540

Pulled By: soumith

fbshipit-source-id: 8ebfed600fc735fd1cb0489b161ec80e3db062e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants