Use shareable calculate-docker-image GHA#105372
Closed
huydhn wants to merge 13 commits intopytorch:mainfrom
Closed
Use shareable calculate-docker-image GHA#105372huydhn wants to merge 13 commits intopytorch:mainfrom
huydhn wants to merge 13 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105372
Note: Links to docs will display an error until the docs builds have been completed. ✅ 1 Unrelated FailureAs of commit 5532210: UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
huydhn
commented
Jul 18, 2023
huydhn
added a commit
to pytorch/test-infra
that referenced
this pull request
Jul 19, 2023
This refactors the logic in PyTorch https://github.com/pytorch/pytorch/blob/main/.github/actions/calculate-docker-image/action.yml to a shareable GHA. Notably, the changes include: * Accept a docker build directory input, i.e. `.ci/docker`, with a `build.sh` script entry. The usage is `build.sh "${IMAGE_NAME}" -t "${DOCKER_IMAGE}"` as how it's used in PyTorch atm * Accept a working directory input because Nova Linux job could checkout the repo in a different directory * Simplify the list of configurable options to only 2 `always-rebuild` and `push` (set to true to push the image to ECR) One hidden caveat is that `calculate-docker-image` requires a full checkout to work as it tries to figure out the Docker tag of the base commit. This means that `fetch-depth: 0` is needed to use this action. This action can then be used in the upcoming CI change on Executorch where the repo could build and use its own Docker image(s). ### Testing * Use the GHA on Nova Linux job #4399 * Use the GHA on PyTorch pytorch/pytorch#105372 * Executorch * Publish Docker image: pytorch/executorch#11 * Use Docker image in Linux job: pytorch/executorch#12
malfet
approved these changes
Jul 19, 2023
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
|
@pytorchbot merge -f "Don't want to wait for ROCM" |
Collaborator
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
huydhn
added a commit
to pytorch/test-infra
that referenced
this pull request
Jul 20, 2023
Add a step in Linux job to calculate and build Docker image if needed. This is similar to how PyTorch CI rebuilds its Docker images atm. ### Testing pytorch/pytorch#105372, PyTorch Lint job uses Linux jobs.
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 24, 2023
As this has been replaced by the more generic calculate-docker-image on test-infra pytorch/test-infra#4397 in: * pytorch/test-infra#4399 * and #105372 Pull Request resolved: #105752 Approved by: https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from PyTorch
calculate-docker-imageGHA to its shareable version on test-infra pytorch/test-infra#4397.I will clean up PyTorch
calculate-docker-imageGHA in a separate PR after landing this one.