[quant][pt2e] change internal code to only import from _quantize_pt2e#105162
Closed
jerryzh168 wants to merge 1 commit intopytorch:mainfrom
Closed
[quant][pt2e] change internal code to only import from _quantize_pt2e#105162jerryzh168 wants to merge 1 commit intopytorch:mainfrom
jerryzh168 wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105162
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit f9e6d76: NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47445767 |
bb59414 to
5e9fed0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47445767 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47445767 |
5e9fed0 to
bb787bb
Compare
andrewor14
approved these changes
Jul 13, 2023
…pytorch#105162) Summary: Pull Request resolved: pytorch#105162 X-link: pytorch/executorch#7 This is to make public api clear so that we can make implementation details change easier in the future Test Plan: CIs Reviewed By: andrewor14 Differential Revision: D47445767 fbshipit-source-id: 008e643a9c8996f7c6846abee1c15a72f6fb4c7d
bb787bb to
f9e6d76
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47445767 |
facebook-github-bot
pushed a commit
to pytorch/executorch
that referenced
this pull request
Jul 14, 2023
Summary: X-link: pytorch/pytorch#105162 Pull Request resolved: #7 This is to make public api clear so that we can make implementation details change easier in the future Reviewed By: andrewor14 Differential Revision: D47445767 fbshipit-source-id: e6887b92e0fe9112c9a106e6ec31a24d080e4028
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This is to make public api clear so that we can make implementation details change easier in the future
Test Plan: CIs
Differential Revision: D47445767