Skip to content

CUDAGraph trees real inputs should never be SymInt#105148

Closed
ezyang wants to merge 2 commits intogh/ezyang/2227/basefrom
gh/ezyang/2227/head
Closed

CUDAGraph trees real inputs should never be SymInt#105148
ezyang wants to merge 2 commits intogh/ezyang/2227/basefrom
gh/ezyang/2227/head

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Jul 13, 2023 •
edited
Loading

@ezyang
CUDAGraph trees real inputs should never be SymInt
3df46e8 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 13, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105148

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 00ac37e:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang ezyang mentioned this pull request Jul 13, 2023
Closed
@ezyang
Update on "CUDAGraph trees real inputs should never be SymInt"
00ac37e 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jul 13, 2023
@ezyang
CUDAGraph trees real inputs should never be SymInt
d4804ed 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 5a6c0aa
Pull Request resolved: #105148
@ezyang ezyang requested a review from eellison July 13, 2023 16:41
eellison
eellison approved these changes Jul 13, 2023 •
edited
Loading
View reviewed changes
@ezyang
Copy link
Contributor Author

ezyang commented Jul 13, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 13, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 13, 2023

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ezyang ezyang added the topic: not user facing topic category label Jul 13, 2023
@ezyang
Copy link
Contributor Author

ezyang commented Jul 13, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 13, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 13, 2023

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / test (default, 1, 3, macos-m1-12)

Details for Dev Infra team Raised by workflow job

@albanD albanD removed their request for review July 13, 2023 20:24
@ezyang
Copy link
Contributor Author

ezyang commented Jul 14, 2023

@pytorchbot merge -f "known master failure"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 14, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn huydhn mentioned this pull request Jul 14, 2023
Closed
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/2227/head branch July 17, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@eellison eellison eellison approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @pytorchmergebot @Skylion007 @eellison