Nomnigraph - Refactor SubtreeMatchCriteria to become a Graph of MatchNode#10512
Closed
duc0 wants to merge 2 commits intopytorch:masterfrom
Closed
Nomnigraph - Refactor SubtreeMatchCriteria to become a Graph of MatchNode#10512duc0 wants to merge 2 commits intopytorch:masterfrom
duc0 wants to merge 2 commits intopytorch:masterfrom
Conversation
Summary: isSubtreeMatch now returns a SubtreeMatchResult which contains a match flag and a debugMessage string that contains the reason why a subtree is not matched (if requested). Differential Revision: D9182429 fbshipit-source-id: 27aee29587df9aadf0dfbadec59e90aae250e4a2
…Node (pytorch#10512) Summary: Pull Request resolved: pytorch#10512 SubtreeMatchCriteria now becomes a graph of MatchNode MatchNode consists of NodeMatchCriteria, nonTerminal and count. This is a cleaner internal representation of the data structure and will bring us much closer to DAG matching. Note that I still keep the debugString method because convertToDotGraph doesn't currently work with Subgraph. Differential Revision: D9321695 fbshipit-source-id: 2e6a0b3a4cd99f9c9baf66790f0ea05434245cf4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
SubtreeMatchCriteria now becomes a graph of MatchNode
MatchNode consists of NodeMatchCriteria, nonTerminal and count. This is a cleaner internal representation of the data structure and will bring us much closer to DAG matching.
Note that I still keep the debugString method because convertToDotGraph doesn't currently work with Subgraph.
Differential Revision: D9321695