Use GitHub REST API to get the merge base commit SHA#105098
Closed
huydhn wants to merge 9 commits intopytorch:mainfrom
Closed
Use GitHub REST API to get the merge base commit SHA#105098huydhn wants to merge 9 commits intopytorch:mainfrom
huydhn wants to merge 9 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105098
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 12e00b0: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
reviewed
Jul 13, 2023
Contributor
Author
|
Notice a bunch of force-merged ghstack PRs today where broken trunks were shown as new failures:
So I add a test case for ghstack to make sure that mergebot correctly recognize them as broken trunk. Also, Dr.CI shouldn't show them as new failures, which I will fix in a separate PR |
malfet
approved these changes
Jul 14, 2023
huydhn
commented
Jul 14, 2023
huydhn
commented
Jul 14, 2023
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #104713
Testing
Manual testing locally using #104121 and confirm that the correct merge base commit is returned 803c14490b189f9b755ecb9f2a969876088ea243 instead of the wrong value provided by
baseRefOid(de7b6e5). Here is the JSON output of the GraphQL query for PR info https://paste.sh/TJ-QQWz4#fvE3Y6qoJ8vDkRBZ3vowkZ3mcc @albanD