[unified build] build changes to make cpu unified build working.#10504
[unified build] build changes to make cpu unified build working.#10504Yangqing wants to merge 10 commits intopytorch:masterfrom
Conversation
caffe2/CMakeLists.txt
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
1c5aeb8 to
b70ce80
Compare
orionr
left a comment
There was a problem hiding this comment.
Awesome! A few questions and comments. Also a real build failure at https://ci.pytorch.org/jenkins/job/caffe2-builds/job/py2-cuda9.0-cudnn7-windows-build/11013/console
aten/src/ATen/core/Macros.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
caffe2/core/registry.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Windows build failure identified as a different cause - landing to unblock other PRs since this is a bit big. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
Yangqing has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Oops - backing out my change. One sec. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
Yangqing has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
Yangqing has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
Yangqing has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…uld probably be AT_CORE_API.
…e to dual CAFFE2_API and [[noreturn]]
facebook-github-bot
left a comment
There was a problem hiding this comment.
Yangqing has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Properly annotated all apis for cpu front. Checked with cmake using cmake -DUSE_ATEN=ON -DUSE_CUDA=OFF -DBUILD_ATEN=ON and resulting libcaffe2.so has about 11k symbols. Pull Request resolved: pytorch/pytorch#10504 Reviewed By: ezyang Differential Revision: D9316491 Pulled By: Yangqing fbshipit-source-id: 215659abf350af7032e9a4b0f28a856babab2454
Summary: Pull Request resolved: pytorch#10565 TSIA Reviewed By: soumith, mingzhe09088 Differential Revision: D9354482 fbshipit-source-id: fb742c2efa39c9e099f630cf8d92ea8478be3079
Summary: A continuation of #10504 for GPU, torch, etc. builds. I was testing with ``` FULL_CAFFE2=1 python setup.py build_deps | tee ~/log.txt cat ~/log.txt | egrep 'undefined refer' | sort | less ``` I'll rebase on master when Yangqing's changes in 10504 land, but putting up for some testing. cc mingzhe09088 anderspapitto ezyang Pull Request resolved: #10507 Reviewed By: Yangqing Differential Revision: D9359606 Pulled By: orionr fbshipit-source-id: c2a3683b3ea5839689f5d2661da0bc9055a54cd2
Summary: A continuation of pytorch/pytorch#10504 for GPU, torch, etc. builds. I was testing with ``` FULL_CAFFE2=1 python setup.py build_deps | tee ~/log.txt cat ~/log.txt | egrep 'undefined refer' | sort | less ``` I'll rebase on master when Yangqing's changes in 10504 land, but putting up for some testing. cc mingzhe09088 anderspapitto ezyang Pull Request resolved: pytorch/pytorch#10507 Reviewed By: Yangqing Differential Revision: D9359606 Pulled By: orionr fbshipit-source-id: c2a3683b3ea5839689f5d2661da0bc9055a54cd2
Properly annotated all apis for cpu front. Checked with cmake using
cmake -DUSE_ATEN=ON -DUSE_CUDA=OFF -DBUILD_ATEN=ON
and resulting libcaffe2.so has about 11k symbols.