Add conversions between DataType and ScalarType.#10472
Closed
ezyang wants to merge 3 commits intopytorch:masterfrom
Closed
Add conversions between DataType and ScalarType.#10472ezyang wants to merge 3 commits intopytorch:masterfrom
ezyang wants to merge 3 commits intopytorch:masterfrom
Conversation
34be216 to
2636912
Compare
gchanan
reviewed
Aug 13, 2018
aten/src/ATen/core/ScalarType.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
2636912 to
0453ea6
Compare
gchanan
reviewed
Aug 13, 2018
aten/src/ATen/core/ScalarType.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
0453ea6 to
97228d5
Compare
97228d5 to
f6ca6b3
Compare
gchanan
approved these changes
Aug 14, 2018
f6ca6b3 to
22b78b7
Compare
22b78b7 to
ab33549
Compare
Summary:
Have you ever written an operator<< overload in the caffe2 namespace
in a core Caffe2 header, and then been stunned when some completely
unrelated code started breaking? This diff fixes this problem!
The problem looks like this:
1. You're building against a really old version of glog (think 0.3.2,
or something like that)
2. This version of glog defines operator<< overloads for std containers
in the global namespace
3. You add a new overload in your current namespace (e.g., caffe2).
Congratulations: this overload is *preferentially* chosen over
the global namespace one for all calls to << in that namespace.
And since it doesn't actually have std::vector overloads, unrelated
Caffe2 code breaks.
Newer versions of glog have a fix for this: they have the line:
namespace std { using ::operator<<; }
in their header. So let's help old versions of glog out and do this ourselves.
In our new world order, operator<< overloads defined in the global namespace
won't work (unless they're for std containers, which work because of ADL).
So this diff also moves all those overloads to the correct namespace.
Differential Revision: D9344540
fbshipit-source-id: 258f7eadfa1969267ef198a60c1886a761d094d3
Differential Revision: D9346040 fbshipit-source-id: 5d25f118c1926fd242ad0229fc5f4fdd17724dca
Summary: Pull Request resolved: pytorch#10472 Reviewed By: gchanan Differential Revision: D9298048 fbshipit-source-id: 79bcf6107fa32af442a9d1263ea0c8a2c80be637
ab33549 to
859ac0b
Compare
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 16, 2018
Summary: Pull Request resolved: pytorch/pytorch#10472 Reviewed By: gchanan Differential Revision: D9298048 fbshipit-source-id: c58efa582eab64c58d0771d90d90862911c168d1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D9298048