Use CUDA_LINK_LIBRARIES_KEYWORD instead of hacking.#10437
Closed
xkszltl wants to merge 1 commit intopytorch:masterfrom
Closed
Use CUDA_LINK_LIBRARIES_KEYWORD instead of hacking.#10437xkszltl wants to merge 1 commit intopytorch:masterfrom
xkszltl wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
|
Thanks! This is great to know. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
Yangqing is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: There's no need to hack. Using `CUDA_LINK_LIBRARIES_KEYWORD` is the normal way. Pull Request resolved: pytorch#10437 Differential Revision: D9287579 Pulled By: Yangqing fbshipit-source-id: d3d575ea8c3235576ba971e4b7493ddb435f92f3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no need to hack.
Using
CUDA_LINK_LIBRARIES_KEYWORDis the normal way.