Skip to content

[ET][XNNPACK] Add support for quantized LeakyReLU#104309

Closed
digantdesai wants to merge 1 commit intopytorch:mainfrom
digantdesai:export-D47043207
Closed

[ET][XNNPACK] Add support for quantized LeakyReLU#104309
digantdesai wants to merge 1 commit intopytorch:mainfrom
digantdesai:export-D47043207

Conversation

@digantdesai
Copy link
Contributor

@digantdesai digantdesai commented Jun 28, 2023

Summary: Also adds support for backend_config

Test Plan: buck test fbcode//mode/dev-nosan fbcode//executorch/backends/xnnpack/test:

Reviewed By: mcr229

Differential Revision: D47043207

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 28, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104309

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 241168c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the release notes: quantization release notes category label Jun 28, 2023
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 28, 2023

This pull request was exported from Phabricator. Differential Revision: D47043207

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 28, 2023

This pull request was exported from Phabricator. Differential Revision: D47043207

salilsdesai
salilsdesai approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@salilsdesai salilsdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 28, 2023

This pull request was exported from Phabricator. Differential Revision: D47043207

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 28, 2023

This pull request was exported from Phabricator. Differential Revision: D47043207

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 28, 2023

This pull request was exported from Phabricator. Differential Revision: D47043207

@digantdesai
Copy link
Contributor Author

digantdesai commented Jun 29, 2023

@pytorchbot merge this

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 29, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: this

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@digantdesai
Copy link
Contributor Author

digantdesai commented Jun 29, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 29, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 29, 2023

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team Raised by workflow job

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 30, 2023

This pull request was exported from Phabricator. Differential Revision: D47043207

@digantdesai @facebook-github-bot
[ET][XNNPACK] Add support for quantized LeakyReLU (pytorch#104309)
241168c 
Summary:
Pull Request resolved: pytorch#104309

X-link: pytorch/executorch#1

Also adds support for backend_config

Test Plan: `buck test fbcode//mode/dev-nosan fbcode//executorch/backends/xnnpack/test:`

Reviewed By: mcr229

Differential Revision: D47043207

fbshipit-source-id: 3e2f7b614713ae5c3fba6ea3056376f15826de17
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 30, 2023

This pull request was exported from Phabricator. Differential Revision: D47043207

facebook-github-bot pushed a commit to pytorch/executorch that referenced this pull request Jun 30, 2023
@digantdesai @facebook-github-bot
Add support for quantized LeakyReLU (#1)
8a5d102 
Summary:
X-link: pytorch/pytorch#104309

Pull Request resolved: #1

Also adds support for backend_config

Reviewed By: mcr229

Differential Revision: D47043207

fbshipit-source-id: 51abd266bba7441c28578f6c58686a3d021d9d2a
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 30, 2023

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 30, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@salilsdesai salilsdesai salilsdesai approved these changes

@manuelcandales manuelcandales manuelcandales approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: AO frontend release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@digantdesai @facebook-github-bot @pytorchmergebot @salilsdesai @manuelcandales