remove implicit conversion to cpu#10416
Closed
ailzhang wants to merge 3 commits intopytorch:masterfrom
Closed
Conversation
fmassa
approved these changes
Aug 10, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
soumith
approved these changes
Aug 14, 2018
Collaborator
|
test seems broken |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@pytorchbot retest this please |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 16, 2018
Summary: Resubmit #10416 with fixed tests . This is to remove implicit conversion from gpu to cpu in when calling numpy to keep behavior match others. It requires users to move the tensor back to cpu() before call numpy functions on it. Pull Request resolved: #10553 Differential Revision: D9350212 Pulled By: ailzhang fbshipit-source-id: 9317d8fea925d4b20ae3150e2c1b39ba5c9c9d0a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9934