Skip to content

[ET][XNNPACK] Add support for quantized Multiply#104134

Closed
digantdesai wants to merge 1 commit intopytorch:mainfrom
digantdesai:export-D46985169
Closed

[ET][XNNPACK] Add support for quantized Multiply#104134
digantdesai wants to merge 1 commit intopytorch:mainfrom
digantdesai:export-D46985169

Conversation

@digantdesai
Copy link
Contributor

Summary:
Also adds support for backend_config with relu fusion since XNNPACK allows it.

We should revisit the relu fusion once we gain more clarity on quantSrcPartition or some other way to do these fusion and not having to add all combinations.

We should really rename the backend config to et_xnnpack.py or something TODO

Test Plan: buck test fbcode//mode/dev-nosan fbcode//executorch/backends/xnnpack/test:

Differential Revision: D46985169

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 24, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104134

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1bff32e:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46985169

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46985169

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46985169

Copy link
Contributor

@salilsdesai salilsdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46985169

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46985169

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46985169

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46985169

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46985169

Summary:
Pull Request resolved: pytorch#104134

Also adds support for backend_config with relu fusion since XNNPACK allows it.

We should revisit the relu fusion once we gain more clarity on quantSrcPartition or some other way to do these fusion and not having to add all combinations.

We should really rename the backend config to et_xnnpack.py or something TODO

Test Plan: `buck test fbcode//mode/dev-nosan fbcode//executorch/backends/xnnpack/test:`

Reviewed By: mcr229

Differential Revision: D46985169

fbshipit-source-id: 74b816e68a412aeccdd5e44450f8ea5aea51e49e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46985169

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 27, 2023
facebook-github-bot pushed a commit to pytorch/executorch that referenced this pull request Jun 27, 2023
Summary:
X-link: pytorch/pytorch#104134

Also adds support for backend_config with relu fusion since XNNPACK allows it.

We should revisit the relu fusion once we gain more clarity on quantSrcPartition or some other way to do these fusion and not having to add all combinations.

We should really rename the backend config to et_xnnpack.py or something TODO

Reviewed By: mcr229

Differential Revision: D46985169

fbshipit-source-id: 30d79d5b5f239545fe5f6619c8047bcb4fc15e5f
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants