generalize order switch ops for 1-3d#10395
Closed
jspark1105 wants to merge 2 commits intopytorch:masterfrom
Closed
generalize order switch ops for 1-3d#10395jspark1105 wants to merge 2 commits intopytorch:masterfrom
jspark1105 wants to merge 2 commits intopytorch:masterfrom
Conversation
81fd228 to
7ca78ef
Compare
7ca78ef to
6772195
Compare
6772195 to
a10ecec
Compare
a10ecec to
8d785d4
Compare
8d785d4 to
6c95868
Compare
6c95868 to
bb2d83f
Compare
bb2d83f to
1b115f2
Compare
Differential Revision: D9176314 fbshipit-source-id: e91f21f249042c9de4ea052e3eb3b8d64c002120
Summary: Pull Request resolved: pytorch#10395 Order switch ops (NCHW2NHWC and NHWC2NCHW) were only supporting 2D images. This diff generalizes them to 1D and 3D, and also add a unit test we didn't have. Reviewed By: protonu Differential Revision: D9261177 fbshipit-source-id: c6831c429cd12af8a3a62425e2d049ae8bc5275b
1b115f2 to
cedbb70
Compare
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10395 Order switch ops (NCHW2NHWC and NHWC2NCHW) were only supporting 2D images. This diff generalizes them to 1D and 3D, and also add a unit test we didn't have. Reviewed By: protonu Differential Revision: D9261177 fbshipit-source-id: 56e7ec54c9a8fb71781ac1336f3f28cf024b4bda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Order switch ops (NCHW2NHWC and NHWC2NCHW) were only supporting 2D images.
This diff generalizes them to 1D and 3D, and also add a unit test we didn't have.
Differential Revision: D9261177