Productionize CRF layer in PyText#10362
Closed
ahhegazy wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
Summary: Pull Request resolved: pytorch#10362 This diff implements a manual export from PyText's CRF module to the caffe2 CRF layer. Note that most of the changes in caffe2/python/crf.py are just formatting changes, the only relevant change is the new class CRFUtils. Reviewed By: hikushalhere Differential Revision: D9234126 fbshipit-source-id: de5f0e724eea86759b543eb582ea7bff3c62e10c
5fd2b07 to
c18ade4
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 22, 2018
Summary: Pull Request resolved: #10362 This diff implements a manual export from PyText's CRF module to the caffe2 CRF layer. Note that most of the changes in caffe2/python/crf.py are just formatting changes, the only relevant change is the new class CRFUtils. Reviewed By: hikushalhere Differential Revision: D9234126 fbshipit-source-id: 1a67d709034660e8b3d5ac840560b56de63e3f69
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#10362 This diff implements a manual export from PyText's CRF module to the caffe2 CRF layer. Note that most of the changes in caffe2/python/crf.py are just formatting changes, the only relevant change is the new class CRFUtils. Reviewed By: hikushalhere Differential Revision: D9234126 fbshipit-source-id: 1a67d709034660e8b3d5ac840560b56de63e3f69
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff implements a manual export from PyText's CRF module to the caffe2 CRF layer.
Note that most of the changes in caffe2/python/crf.py are just formatting changes, the only relevant change is the new class CRFUtils.
Differential Revision: D9234126