Make lengths_host_.CopyFrom synced in LengthsCosineCoherenceOp and LengthsTileOp#10360
Closed
bairdzhang wants to merge 1 commit intopytorch:masterfrom
Closed
Make lengths_host_.CopyFrom synced in LengthsCosineCoherenceOp and LengthsTileOp#10360bairdzhang wants to merge 1 commit intopytorch:masterfrom
bairdzhang wants to merge 1 commit intopytorch:masterfrom
Conversation
ee14a39 to
127d86e
Compare
127d86e to
774d921
Compare
…ngthsTileOp (pytorch#10360) Summary: Pull Request resolved: pytorch#10360 It seems `lengths_host_.CopyFrom(lengthsInput, &context_);` is asynchronous w.r.t. the host while `lengths_host_.CopyFrom(lengthsInput);` is synchronous. However, according to jerryzh168, `lengths_host_.CopyFrom(lengths, &context_); context_.FinishDeviceComputation();` is the safest way to guarantee synchronization. Reviewed By: jerryzh168 Differential Revision: D9197923 fbshipit-source-id: 47523ddc05f9f4eb9e288a4f0cf2625070777e9d
774d921 to
e6305a3
Compare
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…ngthsTileOp (pytorch#10360) Summary: Pull Request resolved: pytorch#10360 It seems `lengths_host_.CopyFrom(lengthsInput, &context_);` is asynchronous w.r.t. the host while `lengths_host_.CopyFrom(lengthsInput);` is synchronous. However, according to jerryzh168, `lengths_host_.CopyFrom(lengths, &context_); context_.FinishDeviceComputation();` is the safest way to guarantee synchronization. Reviewed By: jerryzh168 Differential Revision: D9197923 fbshipit-source-id: 827eb63d9d15c1274851e8301a793aed39d4fa6b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
It seems
lengths_host_.CopyFrom(lengthsInput, &context_);is asynchronous w.r.t. the host whilelengths_host_.CopyFrom(lengthsInput);is synchronous.However, according to jerryzh168,
lengths_host_.CopyFrom(lengths, &context_); context_.FinishDeviceComputation();is the safest way to guarantee synchronization.Differential Revision: D9197923