Move maybeZeroDim to TH, change condition so it doesn't turn off scal…#10333
Closed
gchanan wants to merge 1 commit intopytorch:masterfrom
Closed
Move maybeZeroDim to TH, change condition so it doesn't turn off scal…#10333gchanan wants to merge 1 commit intopytorch:masterfrom
gchanan wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Aug 7, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 9, 2018
…… (#10333) Summary: …ars. Pull Request resolved: pytorch/pytorch#10333 Differential Revision: D9206091 Pulled By: gchanan fbshipit-source-id: 492c50189edc2056aa2acce98d49234d2a54ce39
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Aug 10, 2018
pytorch#10333) Summary: …ars. Pull Request resolved: pytorch#10333 Differential Revision: D9206091 Pulled By: gchanan fbshipit-source-id: 492c50189edc2056aa2acce98d49234d2a54ce39
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
pytorch#10333) Summary: …ars. Pull Request resolved: pytorch#10333 Differential Revision: D9206091 Pulled By: gchanan fbshipit-source-id: 492c50189edc2056aa2acce98d49234d2a54ce39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ars.