[jit][script][easy] Change empty list literal compiler error to match actual builtin name#10265
Closed
[jit][script][easy] Change empty list literal compiler error to match actual builtin name#10265
Conversation
zou3519
approved these changes
Aug 6, 2018
Contributor
zou3519
left a comment
There was a problem hiding this comment.
Should that be lowercase foo? i.e., _construct_empty_int_list instead of _construct_empty_INT_list
Member
Author
|
mm yeah, I was just trying to make clearer that |
Member
Author
|
@pytorchbot retest this please |
zdevito
approved these changes
Aug 7, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
michaelsuo is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…pytorch#10265) Summary: I changed the name of this builtin to match Python's native style, but forgot to change the compiler error to match. Pull Request resolved: pytorch#10265 Differential Revision: D9192963 Pulled By: michaelsuo fbshipit-source-id: 225ca4cd50fbbe3b31c369deeb3123a84342aab1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the name of this builtin to match Python's native style, but forgot to change the compiler error to match.