Move CoreAPI.h to Macros.h, to give it a more accurate name.#10264
Closed
ezyang wants to merge 3 commits intopytorch:masterfrom
Closed
Move CoreAPI.h to Macros.h, to give it a more accurate name.#10264ezyang wants to merge 3 commits intopytorch:masterfrom
ezyang wants to merge 3 commits intopytorch:masterfrom
Conversation
0369ae9 to
f8c847e
Compare
Differential Revision: D9157408 fbshipit-source-id: 2eec927b3252a765f49cf40c89a240df55e92b05
…/core Summary: Auxiliary changes that were needed: - Add DISABLE_COPY_AND_ASSIGN to CoreAPI.h (maybe we should rename this file now) Differential Revision: D9181321 fbshipit-source-id: 10d44f37618990e5642c1fb5e330a3ad17ea74a6
…#10264) Summary: Pull Request resolved: pytorch#10264 Since we now have DISABLE_COPY_AND_ASSIGN macro in the file, CoreAPI is no longer an accurate name. Reviewed By: dzhulgakov Differential Revision: D9181687 fbshipit-source-id: 360a94c59fd38987b3a34381b01b688b3e0a49ea
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 7, 2018
Summary: Pull Request resolved: pytorch/pytorch#10264 Since we now have DISABLE_COPY_AND_ASSIGN macro in the file, CoreAPI is no longer an accurate name. Reviewed By: dzhulgakov Differential Revision: D9181687 fbshipit-source-id: a9cc5556be9c43e6aaa22671f755010707caef67
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…#10264) Summary: Pull Request resolved: pytorch#10264 Since we now have DISABLE_COPY_AND_ASSIGN macro in the file, CoreAPI is no longer an accurate name. Reviewed By: dzhulgakov Differential Revision: D9181687 fbshipit-source-id: a9cc5556be9c43e6aaa22671f755010707caef67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Since we now have DISABLE_COPY_AND_ASSIGN macro in the file,
CoreAPI is no longer an accurate name.
Differential Revision: D9181687