Move TensorTypeId, TensorTypeIdRegistration and flat_hash_map to ATen/core#10263
Closed
ezyang wants to merge 2 commits intopytorch:masterfrom
Closed
Move TensorTypeId, TensorTypeIdRegistration and flat_hash_map to ATen/core#10263ezyang wants to merge 2 commits intopytorch:masterfrom
ezyang wants to merge 2 commits intopytorch:masterfrom
Conversation
Differential Revision: D9157408 fbshipit-source-id: 7da24258ffdc7e37359f55e6ec90607d448ef6bb
…/core (pytorch#10263) Summary: Pull Request resolved: pytorch#10263 Auxiliary changes that were needed: - Add DISABLE_COPY_AND_ASSIGN to CoreAPI.h (maybe we should rename this file now) Differential Revision: D9181321 fbshipit-source-id: f2fe619cf9be50517cb1d66c351209646597f0c4
Contributor
Author
|
This commit revealed that ska Since tensor type ID is not a perf crit path, I'm just going to get rid of the dependence of TensorTypeId on CC @smessmer |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 7, 2018
…/core (#10263) Summary: Pull Request resolved: pytorch/pytorch#10263 Auxiliary changes that were needed: - Add DISABLE_COPY_AND_ASSIGN to CoreAPI.h (maybe we should rename this file now) Reviewed By: dzhulgakov Differential Revision: D9181321 fbshipit-source-id: 975687068285b5a94a57934817c960aeea2bbafa
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…/core (pytorch#10263) Summary: Pull Request resolved: pytorch#10263 Auxiliary changes that were needed: - Add DISABLE_COPY_AND_ASSIGN to CoreAPI.h (maybe we should rename this file now) Reviewed By: dzhulgakov Differential Revision: D9181321 fbshipit-source-id: 975687068285b5a94a57934817c960aeea2bbafa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Auxiliary changes that were needed:
now)
Differential Revision: D9181321