Modify build.sh and test.sh scripts for ppc64le jenkins build and test#10257
Modify build.sh and test.sh scripts for ppc64le jenkins build and test#10257avmgithub wants to merge 18 commits intopytorch:masterfrom avmgithub:master
Conversation
|
|
@ezyang answer to your questions:
|
|
So, I looked at your modified patch: you're still doing what's effectively a copy paste, since you have a giant if-block conditioned on ppc, versus not. If you're going to do that, you might as well just have another file. What I would like to see is a localized block that sets the extra environment variables that PPC needs, and no reindenting of the build script. It would be even better if we had a PPC docker image (similar to the docker images we have for our Linux builds), which can have these environment variables pre-set. The definitions for these currently live in https://github.com/pietern/pytorch-dockerfiles |
|
@ezyang Ok , I got it. For build.sh I can use it as is except for the line WERROR=1 python setup.py install . I am not able to use the line with WERROR=1 . For test.sh , how are you able to run the test while in the pytorch directory? I have to do a "cd .." out of the directory. Otherwise I get an error like below. test_python_nn this is because there is a torch directory in the pytorch repo. Does this not happen on x86 ? |
|
@ezyang, when you get the chance please review the latest revision. |
.jenkins/pytorch/build.sh
Outdated
|
|
||
| WERROR=1 python setup.py install | ||
| if [[ "$BUILD_ENVIRONMENT" == *ppc64le* ]]; then | ||
| export TORCH_CUDA_ARCH_LIST=6.0 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| ln -s "$TORCH_LIB_PATH"/libnccl* build/bin | ||
| if [[ "$BUILD_ENVIRONMENT" == *ppc64le* ]]; then | ||
| SUDO=sudo | ||
| fi |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@pytorchbot retest this please |
|
@ezyang when you get the chance , please review. I tried to do the export WERROR=1 in a separate conditional , but it created a problem when building the ATen install. So it looks like it needs to be in line with the python setup.py install. |
.jenkins/pytorch/build.sh
Outdated
|
|
||
| # Target only our CI GPU machine's CUDA arch to speed up the build | ||
| export TORCH_CUDA_ARCH_LIST=5.2 | ||
| export TORCH_CUDA_ARCH_LIST="5.2 6.0" |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
.jenkins/pytorch/build.sh
Outdated
|
|
||
| WERROR=1 python setup.py install | ||
| # ppc64le build fails when WERROR=1 | ||
| # set only when building other archtectures |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@ezyang please review when you get the chance, hope the changes are OK |
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
pytorch#10257) Summary: Initial jenkins builds / test scripts for ppc64le. Pull Request resolved: pytorch#10257 Differential Revision: D9331278 Pulled By: ezyang fbshipit-source-id: 6d9a4f300a0233faf3051f8151beb31786dcd838
Initial jenkins builds / test scripts for ppc64le.