add BEGIN NOT-CLEAN-FILES marker to .gitignore.#10233
Closed
shkit wants to merge 2 commits intopytorch:masterfrom
shkit:add-not-clean-files-section
Closed
add BEGIN NOT-CLEAN-FILES marker to .gitignore.#10233shkit wants to merge 2 commits intopytorch:masterfrom shkit:add-not-clean-files-section
shkit wants to merge 2 commits intopytorch:masterfrom
shkit:add-not-clean-files-section
Conversation
ezyang
reviewed
Aug 4, 2018
setup.py
Outdated
| os.remove(filename) | ||
| except OSError: | ||
| shutil.rmtree(filename, ignore_errors=True) | ||
| pat = re.compile('^#( BEGIN NOT-CLEAN-FILES )*') |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Aug 4, 2018
Contributor
ezyang
left a comment
There was a problem hiding this comment.
Looks basically reasonable. Don't know if there are other bits which we should preserve (.idea maybe?)
Contributor
|
@shkit How did you test? |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@ezyang I simply type |
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Using Visual Studio Code and Visual Studio, these IDEs store configurations to `FOLDER/.vscode` and `FOLDER/.vs`. But "setup.py clean" deletes these folders because those are described in `.gitignore` file. To prevent this, add "BEGIN NOT-CLEAN-FILES" marker to `.gitignore` file and "setup.py clean" ignores lines after this marker. Discussed in pytorch#10206 Pull Request resolved: pytorch#10233 Differential Revision: D9175515 Pulled By: ezyang fbshipit-source-id: 24074a7e6e505a3d51382dc5ade5c65c97deda37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Visual Studio Code and Visual Studio, these IDEs store configurations to
FOLDER/.vscodeandFOLDER/.vs.But "setup.py clean" deletes these folders because those are described in
.gitignorefile.To prevent this, add "BEGIN NOT-CLEAN-FILES" marker to
.gitignorefile and "setup.py clean" ignores lines after this marker.Discussed in #10206