Generalize intrusive_ptr comment#10216
Closed
smessmer wants to merge 2 commits intopytorch:masterfrom
Closed
Conversation
ezyang
approved these changes
Aug 3, 2018
Summary: Seems we're passing weak pointers over C API boundaries. Need this API there too. Differential Revision: D9154505 fbshipit-source-id: 8d7145bb35fa4d784ac91b9e7147e1a2463fc67d
Summary: Pull Request resolved: pytorch#10216 - Reviewed By: ezyang Differential Revision: D9155601 fbshipit-source-id: c3e32b2064eabc4ab8f3067f8526a41a24b6b40c
6a7794d to
2f79d2a
Compare
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 3, 2018
Summary: Pull Request resolved: pytorch/pytorch#10216 - Reviewed By: ezyang Differential Revision: D9155601 fbshipit-source-id: 154de2e6ad747134413a3ab3ae0b7507b8284d49
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10216 - Reviewed By: ezyang Differential Revision: D9155601 fbshipit-source-id: 154de2e6ad747134413a3ab3ae0b7507b8284d49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: -
Differential Revision: D9155601