Allow releasing/retaining weak_intrusive_ptr#10214
Closed
smessmer wants to merge 1 commit intopytorch:masterfrom
Closed
Allow releasing/retaining weak_intrusive_ptr#10214smessmer wants to merge 1 commit intopytorch:masterfrom
smessmer wants to merge 1 commit intopytorch:masterfrom
Conversation
4818c68 to
3e7259b
Compare
ezyang
approved these changes
Aug 3, 2018
Summary: Pull Request resolved: pytorch#10214 Seems we're passing weak pointers over C API boundaries. Need this API there too. Reviewed By: ezyang Differential Revision: D9154505 fbshipit-source-id: 4de1a3717a717f30137a19c6f7599c61dc96422b
3e7259b to
d41a43b
Compare
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 3, 2018
Summary: Pull Request resolved: pytorch/pytorch#10214 Seems we're passing weak pointers over C API boundaries. Need this API there too. Reviewed By: ezyang Differential Revision: D9154505 fbshipit-source-id: c9889689b87dad5d918f93ba231e01704b8d2479
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10214 Seems we're passing weak pointers over C API boundaries. Need this API there too. Reviewed By: ezyang Differential Revision: D9154505 fbshipit-source-id: c9889689b87dad5d918f93ba231e01704b8d2479
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Seems we're passing weak pointers over C API boundaries. Need this API there too.
Differential Revision: D9154505