Use target_compile_definitions for AT_CORE_STATIC_WINDOWS#10213
Closed
ezyang wants to merge 2 commits intopytorch:masterfrom
Closed
Use target_compile_definitions for AT_CORE_STATIC_WINDOWS#10213ezyang wants to merge 2 commits intopytorch:masterfrom
ezyang wants to merge 2 commits intopytorch:masterfrom
Conversation
Summary: It doesn't work with Caffe2; use AT_CORE_API from ATen/core/CoreAPI.h instead. Differential Revision: D9162467 fbshipit-source-id: 7b22d8cf012d77ca405d39989df1819db876de6d
) Summary: Pull Request resolved: pytorch#10213 nvcc only respects definitions, not options. Reviewed By: dzhulgakov Differential Revision: D9154388 fbshipit-source-id: 0d041688d3eed758b9659140f8be4bfbe161f6c8
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
) Summary: Pull Request resolved: pytorch#10213 nvcc only respects definitions, not options. Reviewed By: dzhulgakov Differential Revision: D9154388 fbshipit-source-id: 04c4809154df1c61108b65f1115fccdeb336952e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: nvcc only respects definitions, not options.
Differential Revision: D9154388