Remove new_Tensor and generated components#10194
Remove new_Tensor and generated components#10194cpuhrsch wants to merge 11 commits intopytorch:masterfrom
Conversation
b543c2c to
93a5641
Compare
aten/src/ATen/TensorImpl.cpp
Outdated
| type_ = &globalContext().getType(backend, scalar_type); | ||
| Storage* storage = type_->storage().release(); | ||
| StorageImpl* storage_impl = storage->pImpl(); | ||
| // storage_impl->retain(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
aten/src/ATen/TensorImpl.cpp
Outdated
| } | ||
|
|
||
| TensorImpl::TensorImpl(Backend backend, ScalarType scalar_type) { | ||
| type_ = &globalContext().getType(backend, scalar_type); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Unfortunately, probably going to conflict with #10210 |
facebook-github-bot
left a comment
There was a problem hiding this comment.
cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| template <typename T, typename Base> | ||
| static inline T* checked_cast_storage(Base* expr, const char * name, int pos, Backend backend, ScalarType scalar_type) { | ||
| template <typename T> | ||
| static inline T* checked_cast_storage(Storage* expr, const char * name, int pos, Backend backend, ScalarType scalar_type) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
aten/src/ATen/ScalarType.h
Outdated
|
|
||
| } // namespace at | ||
|
|
||
| inline std::ostream& operator<<( |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| } | ||
|
|
||
| std::unique_ptr<Storage> TensorImpl::storage() { | ||
| StorageImpl* storage = tensor->storage_; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| StorageImpl* storage_impl = storage->pImpl(); | ||
| // storage_impl->retain(); | ||
| storage_impl->set_resizable(true); | ||
| tensor = new THTensor(storage_impl); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
aten/src/ATen/TensorImpl.cpp
Outdated
| Storage* storage = type_->storage().release(); | ||
| StorageImpl* storage_impl = storage->pImpl(); | ||
| // storage_impl->retain(); | ||
| storage_impl->set_resizable(true); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
aten/src/ATen/TensorImpl.cpp
Outdated
| type_ = &globalContext().getType(backend, scalar_type); | ||
| Storage* storage = type_->storage().release(); | ||
| StorageImpl* storage_impl = storage->pImpl(); | ||
| // storage_impl->retain(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
facebook-github-bot
left a comment
There was a problem hiding this comment.
cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Pull Request resolved: pytorch/pytorch#10194 Differential Revision: D9160559 Pulled By: cpuhrsch fbshipit-source-id: 133185b3d4258c154dc43f7572dbef6bfa6786f3
Summary: Pull Request resolved: pytorch#10194 Differential Revision: D9160559 Pulled By: cpuhrsch fbshipit-source-id: 133185b3d4258c154dc43f7572dbef6bfa6786f3
Summary: Pull Request resolved: pytorch#10194 Differential Revision: D9160559 Pulled By: cpuhrsch fbshipit-source-id: 133185b3d4258c154dc43f7572dbef6bfa6786f3
No description provided.