Add documentation for margin arg in Caffe2 MarginRankingCriterionOp#10186
Closed
ajaech wants to merge 1 commit intopytorch:masterfrom
Closed
Add documentation for margin arg in Caffe2 MarginRankingCriterionOp#10186ajaech wants to merge 1 commit intopytorch:masterfrom
ajaech wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
|
@pytorchbot retest this please |
…ytorch#10186) Summary: Pull Request resolved: pytorch#10186 The MarginRankingCriterionOp margin argument was undocumented. Reviewed By: jerryzh168 Differential Revision: D9141228 fbshipit-source-id: dd9b5f4b2d7c8c62672b7364a6ad558c97c425b3
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…ytorch#10186) Summary: Pull Request resolved: pytorch#10186 The MarginRankingCriterionOp margin argument was undocumented. Reviewed By: jerryzh168 Differential Revision: D9141228 fbshipit-source-id: 724d45dc8e555fbe9d3e8afc7b6bf8ed17bbbdb1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The MarginRankingCriterionOp margin argument was undocumented.
Differential Revision: D9141228