Skip to content

Replace caffe2::EnforceNotMet with at::Error#10184

Closed
ezyang wants to merge 4 commits intopytorch:masterfrom
ezyang:export-D9140095
Closed

Replace caffe2::EnforceNotMet with at::Error#10184
ezyang wants to merge 4 commits intopytorch:masterfrom
ezyang:export-D9140095

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Aug 2, 2018

Differential Revision: D9140095

@ezyang
Copy link
Contributor Author

ezyang commented Aug 3, 2018

@pytorchbot retest this please

ezyang added a commit to ezyang/pytorch that referenced this pull request Aug 3, 2018
Summary: Pull Request resolved: pytorch#10184

Differential Revision: D9140095

fbshipit-source-id: a3f1eb8310307ba6f8178c0280b7477c360fbbed
ezyang added 2 commits August 3, 2018 14:34
Summary:
It doesn't work with Caffe2; use AT_CORE_API from ATen/core/CoreAPI.h
instead.

Differential Revision: D9162467

fbshipit-source-id: 72d85796596d096fdf1e94075085575f563b610e
Summary: nvcc only respects definitions, not options.

Differential Revision: D9154388

fbshipit-source-id: 0cd1078ad11ffc0b8a594208148cd8e45c12b5cf
ezyang added 2 commits August 3, 2018 14:34
Summary:
- New concept of a message stack; you can add messages
  using AppendMessage
- New concept of a caller; it's just a way to pass along
  some arbitrary extra information in the exception

Coming soon is changing Caffe2 to use at::Error instead of
EnforceNotMet

Differential Revision: D9139996

fbshipit-source-id: 5e91baf2abeb013c8fed736a6b3218af407834f2
Summary: Pull Request resolved: pytorch#10184

Reviewed By: dzhulgakov

Differential Revision: D9140095

fbshipit-source-id: 295256efb609890d503144c771d670d51a0f3868
zdevito pushed a commit to zdevito/ATen that referenced this pull request Aug 4, 2018
Summary: Pull Request resolved: pytorch/pytorch#10184

Reviewed By: dzhulgakov

Differential Revision: D9140095

fbshipit-source-id: 3beead825609cec5054347e59903b0b78ef150f8
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
Summary: Pull Request resolved: pytorch#10184

Reviewed By: dzhulgakov

Differential Revision: D9140095

fbshipit-source-id: 3beead825609cec5054347e59903b0b78ef150f8
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant