Make at::Error look more like caffe2::EnforceNotMet#10183
Closed
ezyang wants to merge 3 commits intopytorch:masterfrom
Closed
Make at::Error look more like caffe2::EnforceNotMet#10183ezyang wants to merge 3 commits intopytorch:masterfrom
ezyang wants to merge 3 commits intopytorch:masterfrom
Conversation
dzhulgakov
approved these changes
Aug 3, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: It doesn't work with Caffe2; use AT_CORE_API from ATen/core/CoreAPI.h instead. Differential Revision: D9162467 fbshipit-source-id: bf10e66b0fdb2c6d3757451c5575bd12f7e08b4e
Summary: nvcc only respects definitions, not options. Differential Revision: D9154388 fbshipit-source-id: 580c282cd8c0791f7c19bfefc012252db0ebe061
Summary: - New concept of a message stack; you can add messages using AppendMessage - New concept of a caller; it's just a way to pass along some arbitrary extra information in the exception Coming soon is changing Caffe2 to use at::Error instead of EnforceNotMet Pull Request resolved: pytorch#10183 Differential Revision: D9139996 Pulled By: ezyang fbshipit-source-id: f89dc7ea97d3ee2b96314be61f5b729bc5ebf40b
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 4, 2018
Summary: - New concept of a message stack; you can add messages using AppendMessage - New concept of a caller; it's just a way to pass along some arbitrary extra information in the exception Coming soon is changing Caffe2 to use at::Error instead of EnforceNotMet Pull Request resolved: pytorch/pytorch#10183 Differential Revision: D9139996 Pulled By: ezyang fbshipit-source-id: 6979c289ec59bc3566a23d6619bafba2c1920de9
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: - New concept of a message stack; you can add messages using AppendMessage - New concept of a caller; it's just a way to pass along some arbitrary extra information in the exception Coming soon is changing Caffe2 to use at::Error instead of EnforceNotMet Pull Request resolved: pytorch#10183 Differential Revision: D9139996 Pulled By: ezyang fbshipit-source-id: 6979c289ec59bc3566a23d6619bafba2c1920de9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
using AppendMessage
some arbitrary extra information in the exception
Coming soon is changing Caffe2 to use at::Error instead of
EnforceNotMet
Differential Revision: D9139996