Add g.insertConstant and clean up dead attributes code#10177
Closed
zdevito wants to merge 3 commits intopytorch:masterfrom
Closed
Add g.insertConstant and clean up dead attributes code#10177zdevito wants to merge 3 commits intopytorch:masterfrom
zdevito wants to merge 3 commits intopytorch:masterfrom
Conversation
Replaces insertConstant(g, val), and makes it more consistent with other node construction function. Moves SourceRange to its own header so that we don't have to include the entire lexer in ir.h
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
zdevito has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
reviewed
Aug 2, 2018
| // a range of a shared string 'file_' with functions to help debug by highlight | ||
| // that | ||
| // range. | ||
| struct SourceRange : public SourceLocation { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Aug 2, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
zdevito has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@pytorchbot retest this please |
1 similar comment
Contributor
Author
|
@pytorchbot retest this please |
apaszke
reviewed
Aug 6, 2018
|
|
||
| // note: prefer g.insertConsant(val, loc) which does exactly the same thing | ||
| // this function is only declared/defined here because its implementation is | ||
| // closely related to the implementation of prim::Constant that is also in constants.cpp |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: * Changes `insertConstant(g, val)` to `g.insertConstant(val)`. * Moves SourceRange to its own file to enable it. * Cleans up dead attribute code in schema matching and graph. Pull Request resolved: pytorch#10177 Differential Revision: D9137789 Pulled By: zdevito fbshipit-source-id: 8a73cfb01a576f02e7e4dce019be9c0a0002989d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
insertConstant(g, val)tog.insertConstant(val).