Delete invalid 'template' keyword#10173
Closed
taewookoh wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
Summary: With D9024330, `Extend` fundtion is no more a template, which makes the `template` keyword here invalid. For some reason current version of LLVM doesn't catch this, but the latest one does. Differential Revision: D9133462 fbshipit-source-id: 3cfa9014b70443c67b187163980b386ba342a88f
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10173 With D9024330, `Extend` fundtion is no more a template, which makes the `template` keyword here invalid. For some reason current version of LLVM doesn't catch this, but the latest one does. Reviewed By: jerryzh168 Differential Revision: D9133462 fbshipit-source-id: 54ac9aad01f81b9b4e7b6e2864b8961478d2d860
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
With D9024330,
Extendfundtion is no more a template, which makesthe
templatekeyword here invalid. For some reason current version of LLVMdoesn't catch this, but the latest one does.
Differential Revision: D9133462