Use the symint version of computeStorageNbytes within get_nbytes.#101634
Closed
vanbasten23 wants to merge 4 commits intopytorch:mainfrom
Closed
Use the symint version of computeStorageNbytes within get_nbytes.#101634vanbasten23 wants to merge 4 commits intopytorch:mainfrom
vanbasten23 wants to merge 4 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101634
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e545464: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
hi @ezyang , I followed your suggestion and made the change in this PR. Do you know in which file I should add a test for this PR? |
Contributor
Author
ezyang
approved these changes
May 22, 2023
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
…torch#101634) Fixes [#ISSUE_NUMBER](pytorch/xla#4998) according to [comment](pytorch/xla#4998 (comment)). This change is needed to make sure calling tensor.sizes() will error if the tensor has dynamic dimension in pytorch/xla. Pull Request resolved: pytorch#101634 Approved by: https://github.com/ezyang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_NUMBER according to comment.
This change is needed to make sure calling tensor.sizes() will error if the tensor has dynamic dimension in pytorch/xla.