[c10d] Python binding for reduce,allgather,scatter,gather ops and python tests#10159
Closed
teng-li wants to merge 1 commit intopytorch:masterfrom
Closed
[c10d] Python binding for reduce,allgather,scatter,gather ops and python tests#10159teng-li wants to merge 1 commit intopytorch:masterfrom
teng-li wants to merge 1 commit intopytorch:masterfrom
Conversation
apaszke
approved these changes
Aug 7, 2018
Contributor
apaszke
left a comment
There was a problem hiding this comment.
Why do we only test NCCL?
torch/csrc/distributed/c10d/init.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
|
@teng-li Ping :D |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
teng-li has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 14, 2018
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…ts (pytorch#10159) Summary: Provided python binding for these four ops. Also provided nccl binding test. Based on pytorch#10058 Please only review init.cpp, and test file. Pull Request resolved: pytorch#10159 Reviewed By: yf225 Differential Revision: D9323192 Pulled By: teng-li fbshipit-source-id: b03822009d3a785ec36fecce2fc3071d23f9994e
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Based on pytorch#10159 Please review ProcessGroupMPI.cpp/hpp and init.cpp Pull Request resolved: pytorch#10199 Reviewed By: yf225 Differential Revision: D9324027 Pulled By: teng-li fbshipit-source-id: 2dd524bee0c7ca8f9594ec3b4f3ebbbb608df337
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provided python binding for these four ops. Also provided nccl binding test.
Based on #10058
Please only review init.cpp, and test file.