Use angle brackets instead of quotes for includes.#10153
Closed
ezyang wants to merge 3 commits intopytorch:masterfrom
Closed
Use angle brackets instead of quotes for includes.#10153ezyang wants to merge 3 commits intopytorch:masterfrom
ezyang wants to merge 3 commits intopytorch:masterfrom
Conversation
Summary: We want CaffeTypeId to be interconvertible with at::ScalarType, and this means we should have the numbers line up exactly. Fortunately this is not too hard to do. Differential Revision: D9123058 fbshipit-source-id: f169df2f9962598b82f5d5287f15bc3d24ab5da7
Summary: - Moved from namespace c10::guts to at - I fixed the use sites, since there were only three of them - Macro renamed from C10_ to AT_ Differential Revision: D9123652 fbshipit-source-id: 88c76a0802ed5f92efacce0cd79ed2cb35f544a0
Reviewed By: smessmer Differential Revision: D9123768 fbshipit-source-id: 2c556c9357f0f233d7130ae97b8ef1af7e8806d7
Contributor
Author
|
@pytorchbot retest this please |
2 similar comments
Contributor
Author
|
@pytorchbot retest this please |
Contributor
Author
|
@pytorchbot retest this please |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 2, 2018
Summary: Pull Request resolved: pytorch/pytorch#10153 Reviewed By: smessmer Differential Revision: D9123768 fbshipit-source-id: 0970552ba4d5772fb3cef2db3af3181d98f85140
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10153 Reviewed By: smessmer Differential Revision: D9123768 fbshipit-source-id: 0970552ba4d5772fb3cef2db3af3181d98f85140
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed By: smessmer
Differential Revision: D9123768