[JIT] Python integration for custom operators#10149
[JIT] Python integration for custom operators#10149goldsborough wants to merge 4 commits intopytorch:masterfrom
Conversation
zdevito
left a comment
There was a problem hiding this comment.
Look good. Minor fixes, and we should have tests, but otherwise ready to go.
torch/csrc/jit/init.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/jit/ivalue.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/jit/pybind_utils.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/jit/pybind_utils.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/jit/pybind_utils.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/jit/pybind_utils.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/jit/pybind_utils.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
facebook-github-bot
left a comment
There was a problem hiding this comment.
goldsborough has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Robust error handling for invoke Better error messages, reversed push order, dont expose IValue::Tag Consolidate createStack/wrapStack methods Wrote tests for dynamic binding and argument checking
facebook-github-bot
left a comment
There was a problem hiding this comment.
goldsborough is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Adds the Python path to custom operators, including dynamically loading operations into Python. zdevito Pull Request resolved: pytorch#10149 Reviewed By: ezyang Differential Revision: D9158380 Pulled By: goldsborough fbshipit-source-id: 3edffa639e8d2959e9e80d1bd4f20ab4a1b3ca02
Adds the Python path to custom operators, including dynamically loading operations into Python.
@zdevito