Guard sizes/strides in TH/THC for scalars.#10145
Closed
gchanan wants to merge 1 commit intopytorch:masterfrom
Closed
Guard sizes/strides in TH/THC for scalars.#10145gchanan wants to merge 1 commit intopytorch:masterfrom
gchanan wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
cpuhrsch
reviewed
Aug 2, 2018
| return THTensor_isZeroDim(self) ? 1 : self->size(dim); | ||
| } | ||
|
|
||
| #include "generic/THTensorFastGetSet.hpp" |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
cpuhrsch
reviewed
Aug 2, 2018
| return self->stride(dim); | ||
| } | ||
|
|
||
| int64_t THCTensor_strideLegacyNoScalars(THCState *state, const THCTensor *self, int dim) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
cpuhrsch
approved these changes
Aug 2, 2018
Contributor
cpuhrsch
left a comment
There was a problem hiding this comment.
Looks fine, except two minor comments.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 2, 2018
Summary: Pull Request resolved: pytorch/pytorch#10145 Differential Revision: D9125791 Pulled By: gchanan fbshipit-source-id: d0b8c88c49d7af85971a4531a63fd85a97bfbec7
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10145 Differential Revision: D9125791 Pulled By: gchanan fbshipit-source-id: d0b8c88c49d7af85971a4531a63fd85a97bfbec7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.