Move ATen/Half to ATen/core, and apply lint#10137
Closed
ezyang wants to merge 4 commits intopytorch:masterfrom
Closed
Move ATen/Half to ATen/core, and apply lint#10137ezyang wants to merge 4 commits intopytorch:masterfrom
ezyang wants to merge 4 commits intopytorch:masterfrom
Conversation
Differential Revision: D9119768 fbshipit-source-id: 631b4e15a797781492723a33af1b695389ff32d4
Differential Revision: D9121096 fbshipit-source-id: 0ee9fdd830c42f844b543f48c7b4cf9cde7108d0
…10134) Summary: This will be needed soon because I want to move Half.h into ATen/core, and then I cannot have a TH dependency. I also took the liberty of making the code more strict-aliasing safe (this is not actually useful, since we will never built Torch with strict aliasing) by replacing pointer casts between float and unsigned with a memcpy instead. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: pytorch#10134 Differential Revision: D9121920 fbshipit-source-id: 2ab1012d3df3b4ad39ab6d0c5b26f9779d7f3521
Summary: This rewrites checked_convert to use stringstreams, eliminating the use of to_string which is not available on Android stdc++. Pull Request resolved: pytorch#10137 Differential Revision: D9122340 fbshipit-source-id: 747f0159df76691b99eb832118ac81498ae85308
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 2, 2018
Summary: This rewrites checked_convert to use stringstreams, eliminating the use of to_string which is not available on Android stdc++. Pull Request resolved: pytorch/pytorch#10137 Reviewed By: smessmer Differential Revision: D9122340 fbshipit-source-id: b7c1bff70e36217305f2b3333c51543ef8ff3d9c
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: This rewrites checked_convert to use stringstreams, eliminating the use of to_string which is not available on Android stdc++. Pull Request resolved: pytorch#10137 Reviewed By: smessmer Differential Revision: D9122340 fbshipit-source-id: b7c1bff70e36217305f2b3333c51543ef8ff3d9c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: at::Half is a more featureful version of caffe2::float16, giving you a type for half-precision floats without needing to be compiling with nvcc.
Differential Revision: D9122340