Allow releasing/reclaiming intrusive_ptr#10133
Closed
smessmer wants to merge 1 commit intopytorch:masterfrom
Closed
Allow releasing/reclaiming intrusive_ptr#10133smessmer wants to merge 1 commit intopytorch:masterfrom
smessmer wants to merge 1 commit intopytorch:masterfrom
Conversation
5066858 to
bf234bd
Compare
bf234bd to
9f49877
Compare
9f49877 to
68e8568
Compare
68e8568 to
937a28c
Compare
937a28c to
a0f0ed8
Compare
a0f0ed8 to
6a725e2
Compare
6a725e2 to
15bd19c
Compare
15bd19c to
4664aaa
Compare
ezyang
reviewed
Aug 3, 2018
aten/src/ATen/core/intrusive_ptr.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Aug 3, 2018
4664aaa to
1d9b3ec
Compare
Summary: Pull Request resolved: pytorch#10133 This is useful for C APIs where we want to give owning pointers to/from other languages. Reviewed By: ezyang Differential Revision: D9121493 fbshipit-source-id: b3ab99470e0ac9be24117a9f81f61d325f93965b
1d9b3ec to
d567b57
Compare
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 3, 2018
Summary: Pull Request resolved: pytorch/pytorch#10133 This is useful for C APIs where we want to give owning pointers to/from other languages. Reviewed By: ezyang Differential Revision: D9121493 fbshipit-source-id: f903f5830f587b2ba69c0636ddcf1a066bbac2e0
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10133 This is useful for C APIs where we want to give owning pointers to/from other languages. Reviewed By: ezyang Differential Revision: D9121493 fbshipit-source-id: f903f5830f587b2ba69c0636ddcf1a066bbac2e0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This is useful for C APIs where we want to give owning pointers to/from other languages.
Differential Revision: D9121493