Skip to content

Replace storageimpl type with scalar_type and backend#10097

Closed
cpuhrsch wants to merge 1 commit intopytorch:masterfrom
cpuhrsch:ridimpltype
Closed

Replace storageimpl type with scalar_type and backend#10097
cpuhrsch wants to merge 1 commit intopytorch:masterfrom
cpuhrsch:ridimpltype

Conversation

@cpuhrsch
Copy link
Contributor

@cpuhrsch cpuhrsch commented Jul 31, 2018

No description provided.

@cpuhrsch cpuhrsch force-pushed the ridimpltype branch 2 times, most recently from 430e20a to cc3206f Compare July 31, 2018 22:31
ezyang
ezyang reviewed Aug 1, 2018
View reviewed changes
aten/src/ATen/StorageImpl.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Aug 1, 2018
View reviewed changes
torch/csrc/DynamicTypes.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Aug 1, 2018
View reviewed changes
aten/src/ATen/StorageImpl.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Aug 1, 2018
View reviewed changes
torch/csrc/DynamicTypes.cpp Outdated

This comment was marked as off-topic.

Sign in to view

facebook-github-bot
facebook-github-bot reviewed Aug 1, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ezyang
ezyang reviewed Aug 2, 2018
View reviewed changes
aten/src/ATen/StorageImpl.h

namespace detail {
AT_API Backend get_backend(StorageImpl* storage_impl);
}

This comment was marked as off-topic.

Sign in to view

gchanan
gchanan reviewed Aug 2, 2018
View reviewed changes
aten/src/ATen/StorageImpl.cpp
if (data_ptr.device().is_cuda()) {
return globalContext().getType(Backend::CUDA, scalar_type);
namespace detail {
Backend get_backend(StorageImpl* storage_impl) {

This comment was marked as off-topic.

Sign in to view

zdevito pushed a commit to zdevito/ATen that referenced this pull request Aug 2, 2018
@cpuhrsch @facebook-github-bot
Replace storageimpl type with scalar_type and backend
1a9fc34 
Summary: Pull Request resolved: pytorch/pytorch#10097

Differential Revision: D9124287

Pulled By: cpuhrsch

fbshipit-source-id: c976abeeaaa085b972812c1a3270eb6aef0c0dca
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
@cpuhrsch
Replace storageimpl type with scalar_type and backend
20669a3 
Summary: Pull Request resolved: pytorch#10097

Differential Revision: D9124287

Pulled By: cpuhrsch

fbshipit-source-id: c976abeeaaa085b972812c1a3270eb6aef0c0dca
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gchanan gchanan gchanan left review comments

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ezyang ezyang ezyang approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@colesbury colesbury Awaiting requested review from colesbury

@soumith soumith Awaiting requested review from soumith

@zdevito zdevito Awaiting requested review from zdevito

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cpuhrsch @ezyang @gchanan @facebook-github-bot