inductor(CPU): skip weight packing when autocast is enabled#100844
Closed
XiaobingSuper wants to merge 1 commit intogh/XiaobingSuper/110/basefrom
Closed
inductor(CPU): skip weight packing when autocast is enabled#100844XiaobingSuper wants to merge 1 commit intogh/XiaobingSuper/110/basefrom
XiaobingSuper wants to merge 1 commit intogh/XiaobingSuper/110/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100844
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c381b07: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jgong5
approved these changes
May 8, 2023
Collaborator
jgong5
left a comment
There was a problem hiding this comment.
Please elaborate the motivation and future plan in the description.
jansel
approved these changes
May 8, 2023
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Currently, the packed op doesn't support autocast and the packing path happened before AOTAutograd, which changes the default autocast behavior. Now, we disable the packing path, and the bfloat16 packing path can work after we move this path after AOTAutograd(I will do it after #100652 is done).
cc @soumith @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire