[Reland] Add sym_size/stride/numel/storage_offset to native_function.… by SherlockNoMad · Pull Request #100749 · pytorch/pytorch

SherlockNoMad · 2023-05-05T20:29:26Z

…yaml (#91… (#91919)

Summary:
Pull Request resolved: #91919 Approved by: https://github.com/ezyang

Fixes #ISSUE_NUMBER

Pull Request resolved: #92402

Reviewed By: ezyang

Differential Revision: D42565586

Pulled By: SherlockNoMad

fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9
ghstack-source-id: 969f4928486e04c57aaf98e20e3c3ca946c51613

Fixes #ISSUE_NUMBER

cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire

pytorch-bot · 2023-05-05T20:29:29Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100749

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 84a92f2:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2023-05-05T20:31:41Z

@SherlockNoMad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

albanD

I'm curious why you need these to be native function?

SherlockNoMad · 2023-05-08T21:01:14Z

torch/_dynamo/eval_frame.py

facebook-github-bot · 2023-05-08T21:04:28Z

@SherlockNoMad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

SherlockNoMad · 2023-05-08T21:17:04Z

I'm curious why you need these to be native function?

They need to be properly aten op, so that they can be included in the Core Aten IR.
Also, folks are expecting aten.sym_size to be an OpOverload #97201
Also, we need schema for them.

facebook-github-bot · 2023-05-08T22:08:45Z

@SherlockNoMad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

albanD · 2023-05-08T22:23:28Z

But all of these would work with a registration from python right?

SherlockNoMad · 2023-05-09T17:12:05Z

But all of these would work with a registration from python right?

Sorry, I missed one requirement.
Sigmoid will need to run this op via JIT kernel, and need to access its schema from C++.
So the registration need to be persistent in libtorch.

facebook-github-bot · 2023-05-09T17:14:45Z

@SherlockNoMad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

albanD · 2023-05-09T17:33:07Z

Do you mean a libtorch-only build will need to access it?
The usual dispatcher API to get a kernel even if it wasn't defined in c++. We do that to get our python-registered triton kernel here for example: https://github.com/pytorch/pytorch/blob/8769fb854d816d223cfb513979e97e23a93bddee/aten/src/ATen/native/sparse/SparseBlasImpl.cpp#LL97C10-L97C14

SherlockNoMad · 2023-05-10T19:53:19Z

@pytorchbot rebase -s

pytorchmergebot · 2023-05-10T19:55:32Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2023-05-10T19:55:38Z

Successfully rebased bahuang/sym_size_reland onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout bahuang/sym_size_reland && git pull --rebase)

facebook-github-bot · 2023-05-10T19:57:34Z

@SherlockNoMad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

suo · 2023-05-10T20:22:45Z

Do you mean a libtorch-only build will need to access it?

yeah

pytorchmergebot · 2023-05-12T17:04:05Z

Successfully rebased bahuang/sym_size_reland onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout bahuang/sym_size_reland && git pull --rebase)

facebook-github-bot · 2023-05-12T17:04:35Z

@SherlockNoMad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

SherlockNoMad · 2023-05-12T20:13:54Z

@pytorchbot merge

pytorchmergebot · 2023-05-12T20:15:48Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

malfet · 2023-05-17T00:47:03Z

torch/_dynamo/eval_frame.py

+                arg = super(ChangeInputOutputSignature, self).placeholder(
+                    f"arg{i}", (), {}
+                )
+                # Fill node.mata["val"] with faketensolintrunner from the input,


@suo lintrunner is being immortalized in _dynamo comments :P

malfet · 2023-05-17T00:54:24Z

@pytorchbot revert -m "It makes ExecuTorch sad, please land via codev and have better description" -c ghfirst

pytorchmergebot · 2023-05-17T00:57:23Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2023-05-17T00:57:28Z

Can't revert PR that was landed via phabricator as D42565586. Please revert by going to the internal diff and clicking Unland.

…unction.… (#100749)" This reverts commit bb45489.

malfet · 2023-05-17T01:19:44Z

torch/_dynamo/eval_frame.py

+                    and fake_mode is not None
+                    and isinstance(flat_args[i], torch.Tensor)
+                ):
+                    arg.node.meta["val"] = fake_mode.from_tensor(flat_args[i])


This makes executorch very unhappy, as it tries to compare number of args with number of matched_input_elements_positions, see #99461 / D45106409

malfet · 2023-05-17T01:20:18Z

Manually pushed the revert in 20cf42d

kit1980 · 2023-05-22T17:52:12Z

FYI the correct linked diff for this PR is D45620400

…unction.… (#100749)" This reverts commit bb45489.

#91919) Summary: …yaml (https://github.com/pytorch/pytorch/issues/91… (#91919) Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492 Fixes #ISSUE_NUMBER cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire Pull Request resolved: #100749 SherlockNoMad Differential Revision: D45620400 fbshipit-source-id: 82fafda359febdf9246f63a1355e376ecf17d5cb

facebook-github-bot · 2023-06-06T18:59:12Z

This pull request was exported from Phabricator. Differential Revision: D45620400

Summary: remove _BLACK_LISTED_OPS after pytorch#100749 Test Plan: contbuild & OSS CI Differential Revision: D60056130

Summary: Pull Request resolved: pytorch#131361 remove _BLACK_LISTED_OPS after pytorch#100749 Test Plan: contbuild & OSS CI Differential Revision: D60056130

Summary: remove _BLACK_LISTED_OPS after #100749 Test Plan: contbuild & OSS CI Differential Revision: D60056130 Pull Request resolved: #131361 Approved by: https://github.com/angelayi

Summary: remove _BLACK_LISTED_OPS after pytorch#100749 Test Plan: contbuild & OSS CI Differential Revision: D60056130 Pull Request resolved: pytorch#131361 Approved by: https://github.com/angelayi

SherlockNoMad requested review from albanD and soulitzer as code owners May 5, 2023 20:29

pytorch-bot bot added the release notes: jit release notes category label May 5, 2023

SherlockNoMad added the topic: not user facing topic category label May 5, 2023

SherlockNoMad requested review from suo and zhxchen17 May 5, 2023 20:31

albanD reviewed May 8, 2023

View reviewed changes

SherlockNoMad force-pushed the bahuang/sym_size_reland branch from bd7c850 to 732495a Compare May 8, 2023 21:00

github-actions bot added ciflow/inductor module: dynamo labels May 8, 2023

SherlockNoMad commented May 8, 2023

View reviewed changes

SherlockNoMad force-pushed the bahuang/sym_size_reland branch 2 times, most recently from 2670da5 to d09f044 Compare May 8, 2023 22:04

SherlockNoMad force-pushed the bahuang/sym_size_reland branch from d09f044 to 5ccaee0 Compare May 9, 2023 17:14

zhxchen17 approved these changes May 9, 2023

View reviewed changes

pytorchmergebot force-pushed the bahuang/sym_size_reland branch from 5ccaee0 to 5def2ea Compare May 10, 2023 19:55

pytorchmergebot force-pushed the bahuang/sym_size_reland branch from 3236705 to 84a92f2 Compare May 12, 2023 17:04

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 12, 2023

pytorchmergebot added the merging label May 12, 2023

pytorchmergebot added Merged and removed merging labels May 12, 2023

pytorchmergebot closed this in bb45489 May 12, 2023

malfet reviewed May 17, 2023

View reviewed changes

malfet added a commit that referenced this pull request May 17, 2023

Revert "[Reland] Add sym_size/stride/numel/storage_offset to native_f…

20cf42d

…unction.… (#100749)" This reverts commit bb45489.

malfet reviewed May 17, 2023

View reviewed changes

malfet added the Reverted label May 22, 2023

jcaip pushed a commit that referenced this pull request May 23, 2023

Revert "[Reland] Add sym_size/stride/numel/storage_offset to native_f…

cc4094b

…unction.… (#100749)" This reverts commit bb45489.

yushangdi added a commit to yushangdi/pytorch that referenced this pull request Jul 22, 2024

Remove _BLACK_LISTED_OPS

717594d

Summary: remove _BLACK_LISTED_OPS after pytorch#100749 Test Plan: contbuild & OSS CI Differential Revision: D60056130

yushangdi mentioned this pull request Jul 22, 2024

Remove _BLACK_LISTED_OPS #131361

Closed

Conversation

SherlockNoMad commented May 5, 2023 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100749

✅ No Failures

Uh oh!

facebook-github-bot commented May 5, 2023

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

SherlockNoMad May 8, 2023

Choose a reason for hiding this comment

Uh oh!

tugsbayasgalan May 8, 2023

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented May 8, 2023

Uh oh!

SherlockNoMad commented May 8, 2023

Uh oh!

facebook-github-bot commented May 8, 2023

Uh oh!

albanD commented May 8, 2023

Uh oh!

SherlockNoMad commented May 9, 2023

Uh oh!

facebook-github-bot commented May 9, 2023

Uh oh!

albanD commented May 9, 2023

Uh oh!

SherlockNoMad commented May 10, 2023

Uh oh!

pytorchmergebot commented May 10, 2023

Uh oh!

pytorchmergebot commented May 10, 2023

Uh oh!

facebook-github-bot commented May 10, 2023

Uh oh!

suo commented May 10, 2023

Uh oh!

pytorchmergebot commented May 12, 2023

Uh oh!

facebook-github-bot commented May 12, 2023

Uh oh!

SherlockNoMad commented May 12, 2023

Uh oh!

pytorchmergebot commented May 12, 2023

Merge started

Uh oh!

malfet May 17, 2023

Choose a reason for hiding this comment

Uh oh!

malfet commented May 17, 2023

Uh oh!

pytorchmergebot commented May 17, 2023

Uh oh!

pytorchmergebot commented May 17, 2023

Uh oh!

malfet May 17, 2023

Choose a reason for hiding this comment

Uh oh!

malfet commented May 17, 2023

Uh oh!

kit1980 commented May 22, 2023

Uh oh!

facebook-github-bot commented Jun 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

SherlockNoMad commented May 5, 2023 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented May 5, 2023 •

edited

Loading