Make StorageImpl member variables largely private and use getters and setters by cpuhrsch · Pull Request #10074 · pytorch/pytorch

cpuhrsch · 2018-07-31T15:20:59Z

No description provided.

facebook-github-bot

cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

aten/src/ATen/StorageImpl.h

cpuhrsch · 2018-07-31T22:36:51Z

I'm going to try applying the suggested changes, but more likely than not i'll need to close this and do one member variable at a time.

aten/src/ATen/StorageImpl.h

aten/src/ATen/THLongStorageView.h

aten/src/TH/generic/THStorage.cpp

ezyang

leaks memory

facebook-github-bot

cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

aten/src/ATen/Storage.h

aten/src/ATen/THLongStorageView.h

ezyang

There are some hokey bits but I'm OK leaving them for follow ups.

setters

aten/src/TH/generic/THTensor.cpp

  return 1;
 }

+int THTensor_(isSize)(const THTensor *self, const THLongStorage *dims)


aten/src/THC/generic/THCTensor.cpp

  return THCTensor_isContiguous(state, self);
 }

+int THCTensor_(isSize)(THCState *state, const THCTensor *self, const THLongStorage *dims)


facebook-github-bot

cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… setters Summary: Pull Request resolved: pytorch/pytorch#10074 Differential Revision: D9086887 Pulled By: cpuhrsch fbshipit-source-id: d2dd0d6a1b71d0f864aefb64cd1daefd11dcfb91

… setters Summary: Pull Request resolved: pytorch#10074 Differential Revision: D9086887 Pulled By: cpuhrsch fbshipit-source-id: d2dd0d6a1b71d0f864aefb64cd1daefd11dcfb91

cpuhrsch requested review from apaszke, colesbury, ezyang, gchanan, soumith and zdevito as code owners July 31, 2018 15:20

facebook-github-bot reviewed Jul 31, 2018

View reviewed changes

cpuhrsch force-pushed the storgetters branch 2 times, most recently from d5de698 to 25a1b8d Compare July 31, 2018 21:40

ezyang reviewed Jul 31, 2018

View reviewed changes

aten/src/ATen/StorageImpl.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed Jul 31, 2018

View reviewed changes

aten/src/ATen/StorageImpl.h Outdated

This comment was marked as off-topic.

Sign in to view

cpuhrsch force-pushed the storgetters branch 2 times, most recently from b71c576 to b782a30 Compare July 31, 2018 22:36