Correctly set CAFFE2_DISABLE_NUMA when USE_NUMA=OFF in cmake#10061
Closed
bddppq wants to merge 1 commit intopytorch:masterfrom
Closed
Correctly set CAFFE2_DISABLE_NUMA when USE_NUMA=OFF in cmake#10061bddppq wants to merge 1 commit intopytorch:masterfrom
bddppq wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@pytorchbot retest this please |
pjh5
approved these changes
Jul 31, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 31, 2018
Summary: previously https://github.com/pytorch/pytorch/blob/master/caffe2/core/numa.cc still gets compiled even when USE_NUMA=OFF Pull Request resolved: pytorch/pytorch#10061 Reviewed By: houseroad Differential Revision: D9081385 Pulled By: bddppq fbshipit-source-id: ad28b647e0033727839770b1da0fba341b1b7787
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…#10061) Summary: previously https://github.com/pytorch/pytorch/blob/master/caffe2/core/numa.cc still gets compiled even when USE_NUMA=OFF Pull Request resolved: pytorch#10061 Reviewed By: houseroad Differential Revision: D9081385 Pulled By: bddppq fbshipit-source-id: ad28b647e0033727839770b1da0fba341b1b7787
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously https://github.com/pytorch/pytorch/blob/master/caffe2/core/numa.cc still gets compiled even when USE_NUMA=OFF