Skip to content

PyTorch -> C++17 (#98209)#100557

Closed
r-barnes wants to merge 7 commits intopytorch:mainfrom
r-barnes:export-D44356879
Closed

PyTorch -> C++17 (#98209)#100557
r-barnes wants to merge 7 commits intopytorch:mainfrom
r-barnes:export-D44356879

Conversation

@r-barnes
Copy link
Copy Markdown
Contributor

@r-barnes r-barnes commented May 3, 2023 •
edited by ghost
Loading

🤖 Generated by Copilot at 4f0b524

This pull request updates the codebase and the documentation to use C++17 instead of C++14 as the minimum required C++ standard. This affects the ATen, c10, and torch libraries and their dependencies, as well as the CI system and the conda package metadata.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

@r-barnes r-barnes requested a review from a team as a code owner May 3, 2023 16:27
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented May 3, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100557

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 32db672:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@r-barnes r-barnes force-pushed the export-D44356879 branch from 5b8ea48 to 1ca80c4 Compare May 3, 2023 16:27
@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label May 3, 2023
@github-actions github-actions bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label May 3, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 3, 2023

This pull request was exported from Phabricator. Differential Revision: D44356879

@r-barnes r-barnes closed this May 3, 2023
@r-barnes r-barnes reopened this May 3, 2023
@r-barnes r-barnes added ciflow/trunk Trigger trunk jobs on your pull request release notes: cpp release notes category release notes: build release notes category topic: bc breaking topic category topic: deprecation topic category topic: new features topic category topic: improvements topic category topic: docs topic category topic: build labels May 3, 2023
@r-barnes r-barnes requested a review from malfet May 3, 2023 16:35
@r-barnes
Copy link
Copy Markdown
Contributor Author

r-barnes commented May 3, 2023

pytorchbot rebase -c main

@r-barnes
Copy link
Copy Markdown
Contributor Author

r-barnes commented May 3, 2023

@pytorchbot rebase -c main

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented May 3, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -c main

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@r-barnes @facebook-github-bot
PyTorch -> C++17 (pytorch#100557)
52b3259 
Summary:
Pull Request resolved: pytorch#100557

Pull Request resolved: pytorch#98209

#buildmore

Test Plan: Sandcastle

Reviewed By: VasuAgrawal, malfet

Differential Revision: D44356879

fbshipit-source-id: 0d59faf9ebbfc1597e6ce643efb6c0eeabdb6caf
@malfet
Copy link
Copy Markdown
Contributor

malfet commented May 3, 2023

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 3, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 3, 2023

Tried to rebase and push PR #100557, but it was already up to date

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 3, 2023

This pull request was exported from Phabricator. Differential Revision: D44356879

@r-barnes r-barnes force-pushed the export-D44356879 branch from 1ca80c4 to 52b3259 Compare May 3, 2023 16:42
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 11, 2023

@r-barnes has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 12, 2023

@r-barnes has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jeanschmidt
Copy link
Copy Markdown
Contributor

jeanschmidt commented May 12, 2023

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 12, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 12, 2023

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/main pull/100557/head returned non-zero exit code 1

Rebasing (1/4)
Auto-merging .github/ci_commit_pins/multipy.txt
CONFLICT (content): Merge conflict in .github/ci_commit_pins/multipy.txt
error: could not apply 52b32599650... PyTorch -> C++17 (#100557)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 52b32599650... PyTorch -> C++17 (#100557)

Raised by https://github.com/pytorch/pytorch/actions/runs/4957920430

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 17, 2023

@r-barnes has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@malfet
Copy link
Copy Markdown
Contributor

malfet commented May 19, 2023

@pytorchbot merge -f "Landed internally"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 19, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pmeier pmeier mentioned this pull request May 20, 2023
Merged
malfet added a commit to malfet/DeepSpeed that referenced this pull request May 23, 2023
@malfet
Fix op_builder against PyTorch nightly
06bdf03 
After pytorch/pytorch#100557 PyTorch is free to use C++17 feature in it's headers, such as `std::optional`, `if constexpr` etc.

This update language standard for DS extensions to use C++17 standard by default
This was referenced May 23, 2023
Merged
Closed
@xwang233 xwang233 mentioned this pull request Jun 5, 2023
Merged
8 tasks
@r-barnes r-barnes deleted the export-D44356879 branch June 23, 2023 00:47
@fecet fecet mentioned this pull request Jul 13, 2023
Merged
@videodanchik videodanchik mentioned this pull request Oct 13, 2023
Closed
Yannicked added a commit to Yannicked/SparseConvNet that referenced this pull request Oct 18, 2023
@Yannicked
Use C++17
0ceb5da 
The PyTorch codebase has migrated from the C++14 to the C++17
standard, see: pytorch/pytorch#100557
@Yannicked Yannicked mentioned this pull request Oct 18, 2023
Merged
@droberts195 droberts195 mentioned this pull request Oct 18, 2023
Closed
@thomas-bouvier thomas-bouvier mentioned this pull request Nov 1, 2023
Merged
4 tasks
@njzjz njzjz mentioned this pull request Nov 16, 2023
Merged
5 tasks
@zhijie-yang zhijie-yang mentioned this pull request Oct 13, 2023
Closed
@bell-one bell-one mentioned this pull request Feb 27, 2024
Merged
@ScorpioCh1312 ScorpioCh1312 mentioned this pull request Aug 8, 2024
Open
@matbun matbun mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: cpu CPU specific problem (e.g., perf, algorithm) release notes: build release notes category release notes: cpp release notes category release notes: releng release notes category Reverted topic: bc breaking topic category topic: build topic: deprecation topic category topic: docs topic category topic: improvements topic category topic: new features topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@r-barnes @facebook-github-bot @malfet @pytorchmergebot @jeanschmidt @kit1980