Closed
Conversation
e1cc9fd to
11253de
Compare
11253de to
8cf1e8d
Compare
8cf1e8d to
54126a6
Compare
54126a6 to
a13c6b1
Compare
a13c6b1 to
2e270b4
Compare
2e270b4 to
f2b1a4b
Compare
f2b1a4b to
d9d7909
Compare
d9d7909 to
711485c
Compare
Contributor
Author
|
@pytorchbot retest this please |
1 similar comment
Contributor
Author
|
@pytorchbot retest this please |
711485c to
0373524
Compare
0373524 to
ac2f7b9
Compare
ac2f7b9 to
90ec6fe
Compare
90ec6fe to
fec035d
Compare
fec035d to
e8678ca
Compare
Summary: Pull Request resolved: pytorch#10053 Tensor in Pytorch 1.0 will have Tensor -> TensorImpl -> Storage -> StorageImpl In this diff we split Storage from Tensor in order to align with this design. We'll have Tensor -> Storage -> StorageImpl after this diff Reviewed By: dzhulgakov Differential Revision: D9076734 fbshipit-source-id: a9bef96bec6b2e570434c139951a266d4ecaf378
e8678ca to
b64ad76
Compare
jerryzh168
added a commit
to jerryzh168/pytorch
that referenced
this pull request
Aug 22, 2018
Summary: Pull Request resolved: pytorch#10053 Tensor in Pytorch 1.0 will have Tensor -> TensorImpl -> Storage -> StorageImpl In this diff we split Storage from Tensor in order to align with this design. We'll have Tensor -> Storage -> StorageImpl after this diff Reviewed By: ezyang Differential Revision: D9384781 fbshipit-source-id: ee3a5a8641436743320f62a346971f407fc51c0c
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 22, 2018
Summary: Pull Request resolved: #10053 Tensor in Pytorch 1.0 will have Tensor -> TensorImpl -> Storage -> StorageImpl In this diff we split Storage from Tensor in order to align with this design. We'll have Tensor -> Storage -> StorageImpl after this diff Reviewed By: ezyang Differential Revision: D9384781 fbshipit-source-id: 40ded2437715a3a2cc888ef28cbca9a25b1d5350
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#10053 Tensor in Pytorch 1.0 will have Tensor -> TensorImpl -> Storage -> StorageImpl In this diff we split Storage from Tensor in order to align with this design. We'll have Tensor -> Storage -> StorageImpl after this diff Reviewed By: ezyang Differential Revision: D9384781 fbshipit-source-id: 40ded2437715a3a2cc888ef28cbca9a25b1d5350
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Tensor in Pytorch 1.0 will have
Tensor -> TensorImpl -> Storage -> StorageImpl
In this diff we split Storage from Tensor in order to align with this design.
We'll have Tensor -> Storage -> StorageImpl after this diff
Differential Revision: D9076734