Closed
Conversation
Summary: Pull Request resolved: pytorch#10044 The test was subtly broken! This transform wasn't writing to the correct blob and the test did not catch that because it was looking at the old version. thanks @[100022211048576:kerenzhou] for catching this Reviewed By: Jokeren Differential Revision: D9075520 fbshipit-source-id: 30aa9fb22b9fcbf39d387d9a10b1faf2f05511ef
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10044 The test was subtly broken! This transform wasn't writing to the correct blob and the test did not catch that because it was looking at the old version. thanks @[100022211048576:kerenzhou] for catching this Reviewed By: Jokeren Differential Revision: D9075520 fbshipit-source-id: c31ff0afcd78dd2dc7ffc240e2e89eeda87f1fb4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The test was subtly broken! This transform wasn't writing to the correct blob and the test did not catch that because it was looking at the old version.
thanks @[100022211048576:kerenzhou] for catching this
Differential Revision: D9075520